Make goto_{model,functions}t::unload return a value #7678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable its use in place of .erase(...) when such a call required the number of functions that had been removed. The key user will be a refactored initialize-function re-creation code.
tautschnig
requested review from
romainbrenguier,
peterschrammel and
kroening
as code owners
4 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7678 +/- ##
========================================
Coverage 78.52% 78.52%
========================================
Files 1674 1674
Lines 191971 191973 +2
========================================
+ Hits 150738 150740 +2
Misses 41233 41233
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
kroening
reviewed
Apr 21, 2023
| /// Remove the function named \p name from the function map, if it exists. | ||
| /// \return Returns 0 when \p name was not present, and 1 when \p name was | ||
| /// removed. | ||
| std::size_t unload(const key_type &name) const |
There was a problem hiding this comment.
Is using std::size_t for this purpose a thing?
There was a problem hiding this comment.
Would you recommend using underlying_mapt::size_type instead? That's the exact return type of erase, but I'd expect it to be std::size_t on all platforms.
peterschrammel
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable its use in place of .erase(...) when such a call required the number of functions that had been removed. The key user will be a refactored initialize-function re-creation code.